class Helper{

public function getFormattedUser($a){
$user = new User($a);
return $user-name.' '.$user-surname;
}
}

Where is the problem on this code?

Question

class Helper{

public function getFormattedUser($a){
        $user = new User($a);
        return $user->name.' '.$user->surname;
}
}

Where is the problem on this code?

Anonym · Accepted Answer

of this code smells. $user->name.' '.$user->surname. etc. We have to use $user->getName() better or using magic __get  would be better for this situation.

The classname has to be UserHelper or similar...

Pepper

Frage im Vorstellungsgespräch bei Pepper

Antwort im Vorstellungsgespräch

Beobachtete Unternehmen

Jobsuchen